-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: feeds check #441
feat: feeds check #441
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, some comments
The purpose of the feed check is to enable running it as a regression test. To achieve this, we need some output from the first run that can be reused in subsequent runs (e.g., after updating the Docker image of the node). The process of generating and retrieving this output should be straightforward. The output can be displayed in the console, but we could also store it in a file for convenience. To simplify automation, we could follow a sequence of commands like this:
However, additional modifications to Beekeeper would be required to handle these two flags (--input and --output). This approach can be generalized for other regression tests in the future. @istae, @acha-bill What are your thoughts on this? |
This feed check is in 2 parts—the integration and regression tests. We went with an approach similar to long availability tests for the regression test. We try to retrieve a feed that already exists on public testnet The approach you propose is neat as well since it can be run locally or in CI without the public testnet. |
No description provided.