Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feeds check #441

Merged
merged 8 commits into from
Jan 13, 2025
Merged

feat: feeds check #441

merged 8 commits into from
Jan 13, 2025

Conversation

acha-bill
Copy link
Contributor

No description provided.

Copy link
Member

@istae istae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, some comments

pkg/check/feed/feed.go Outdated Show resolved Hide resolved
pkg/check/feed/feed.go Outdated Show resolved Hide resolved
pkg/check/feed/feed.go Outdated Show resolved Hide resolved
@gacevicljubisa
Copy link
Contributor

gacevicljubisa commented Jan 9, 2025

The purpose of the feed check is to enable running it as a regression test. To achieve this, we need some output from the first run that can be reused in subsequent runs (e.g., after updating the Docker image of the node).

The process of generating and retrieving this output should be straightforward. The output can be displayed in the console, but we could also store it in a file for convenience.

To simplify automation, we could follow a sequence of commands like this:

beekeeper check --cluster-name=default --checks=feed --output=example.yaml  
beekeeper restart --cluster-name=default --image=ethersphere/bee:latest  
beekeeper check --cluster-name=default --checks=feed --input=example.yaml  

However, additional modifications to Beekeeper would be required to handle these two flags (--input and --output).

This approach can be generalized for other regression tests in the future.

@istae, @acha-bill What are your thoughts on this?

@acha-bill
Copy link
Contributor Author

This feed check is in 2 parts—the integration and regression tests. We went with an approach similar to long availability tests for the regression test. We try to retrieve a feed that already exists on public testnet

The approach you propose is neat as well since it can be run locally or in CI without the public testnet.
If we agree to proceed with this new approach, I can strip off the regression part from this PR and keep the integration.

@acha-bill acha-bill merged commit ca85360 into master Jan 13, 2025
3 checks passed
@acha-bill acha-bill deleted the feat/feeds-check branch January 13, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants