fix(Stamp): Gas golfing #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tives into gas_golf_stamp
mfw78
reviewed
Aug 23, 2023
There was a problem hiding this comment.
Great gas golfing, but approach with caution: NethermindEth/nethermind#6024
thnx on this info, good to know. hopefully they resolve this fully. |
mrekucci
reviewed
Aug 24, 2023
nugaon
approved these changes
Sep 5, 2023
|
|
||
| // Price from the last update. | ||
| uint256 public lastPrice = 0; | ||
| uint64 public lastPrice; |
There was a problem hiding this comment.
I wouldn't narrow this variable that much, who knows!
| lastPrice = _price; | ||
| lastUpdatedBlock = block.number; | ||
| lastPrice = uint64(_price); | ||
| lastUpdatedBlock = uint64(block.number); | ||
|
|
||
| emit PriceUpdate(_price); | ||
| } | ||
|
|
||
| function setMinimumValidityBlocks(uint256 _value) external { |
There was a problem hiding this comment.
why not change the parameter as well?
zelig
approved these changes
Sep 24, 2023
|
was overriden in some merge, changes are not in master, will need to reapply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improv.txt
gas-report.txt
Optimization of PostageStamp contract for less gas usage.
Added improv diff that shows improvements on most counts with Stamp and final gas report.