feat: add script and task for migration #208
Conversation
…tives into feat/stamp_migration
| // it('should transfer the token', async function () { | ||
| // await postageStampStamper.copyBatch( | ||
| // stamper, | ||
| // batch.initialPaymentPerChunk, | ||
| // batch.depth, | ||
| // batch.bucketDepth, | ||
| // batch.nonce, | ||
| // batch.immutable | ||
| // ); | ||
| // expect(await token.balanceOf(stamper)).to.equal(0); | ||
| // }); | ||
|
|
||
| // it('should not create batch if insufficient funds', async function () { | ||
| // await expect( | ||
| // postageStampStamper.copyBatch( | ||
| // stamper, | ||
| // batch.initialPaymentPerChunk + 1, | ||
| // batch.depth, | ||
| // batch.bucketDepth, | ||
| // batch.nonce, | ||
| // batch.immutable | ||
| // ) | ||
| // ).to.be.revertedWith(errors.erc20.exceedsBalance); | ||
| // }); |
There was a problem hiding this comment.
Because we are removing erc20 transfers, if you remember we talked about withdrawing funds, if we withdraw then we just fund the new contract with that amount we dont transfer erc20 with each trx and there is really no need to as we dont track amount of funds each person has, its all pooled together.
There was a problem hiding this comment.
and what will ensure that we have the sufficient amount of funds in the new contract?
There was a problem hiding this comment.
This was not ensuring we had a sufficient amount of funds in the new contract anyway. Was just checking if basic erc20 methods are working.
We talked about this many times on synchs, we can go over it again if needed and discuss it if there are some concerns.
The summary is that we are not going to do erc20 token transfers on each batch migration. With that, we can't have these tests as they won't work.
| // it('should transfer the token', async function () { | ||
| // await postageStampStamper.copyBatch( | ||
| // stamper, | ||
| // batch.initialPaymentPerChunk, | ||
| // batch.depth, | ||
| // batch.bucketDepth, | ||
| // batch.nonce, | ||
| // batch.immutable | ||
| // ); | ||
| // expect(await token.balanceOf(stamper)).to.equal(0); | ||
| // }); | ||
|
|
||
| // it('should not create batch if insufficient funds', async function () { | ||
| // await expect( | ||
| // postageStampStamper.copyBatch( | ||
| // stamper, | ||
| // batch.initialPaymentPerChunk + 1, | ||
| // batch.depth, | ||
| // batch.bucketDepth, | ||
| // batch.nonce, | ||
| // batch.immutable | ||
| // ) | ||
| // ).to.be.revertedWith(errors.erc20.exceedsBalance); | ||
| // }); |
There was a problem hiding this comment.
and what will ensure that we have the sufficient amount of funds in the new contract?
scripts/tenderly_reset.ts
Outdated
| @@ -0,0 +1,92 @@ | |||
| // Run this only when you have NEW Tenderly FORK and what to do a new SETUP for it. | |||
There was a problem hiding this comment.
could you rephrase this description please? it is a bit vague for me what tenderly fork is, when I have new one and and what should I do with its setup
There was a problem hiding this comment.
yes, will do better.
scripts/tenderly_reset.ts
Outdated
| await deleteFiles(filesToDelete); | ||
| await deleteDirectory(directoryToDelete); | ||
|
|
||
| const forkId = network.config.url.split('/').slice(-2).join('/'); |
There was a problem hiding this comment.
Property 'url' does not exist on type 'NetworkConfig'.
There was a problem hiding this comment.
yeah, it does exist but type is
export type NetworkConfig = HardhatNetworkConfig | HttpNetworkConfig;
I made type check now.
| from: networkConfig['mainnet'].multisig, | ||
| to: staking.address, | ||
| input: | ||
| '0x2f2ff15d0000000000000000000000000000000000000000000000000000000000000000000000000000000000000000b1c7f17ed88189abf269bf68a3b2ed83c5276aae', |
There was a problem hiding this comment.
There is a comment above this what does this do.
No description provided.