-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat:oracle proper implementation #227
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I imagined this like we calculate bitshifted values in the fields
and in accessor we shift to the real currentPrice
.
will it keep the subtle changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So when we discussed this, the idea was that giving a separate accessor for currentPrice
which is already bitshifted by 10, and the accessor takes this value and shift it back by 10. instead, we have two variables now with which we need to juggle.
but then values between will be lost. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so now we have currentPriceUpscaled as we discussed, but it could be applied to minimumPrice as well.
No description provided.