-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: SWIP 21 #275
feat: SWIP 21 #275
Conversation
…ork properly as well as isParticipatingInUpcomingRound function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to find some other occurrence when height
is handled outside of calculateEffectiveStake
but I did not find.
I thought that manageStake
will do something with the stake based on the height value.
also, please add a test when a node could not play in the round with height 0 |
I tried to make something like this, The problem is that when you change height you are triggering "MustStake2Rounds" as it is affecting the staking struct and we require by default that any staking changes enforces node out of play for 2 rounds. which is not a problem really as it wont be playing in those 2 rounds anyway but its problem for testing as actually after 2 rounds anchor is different so we are not testing much other then if node can play on different anchor with higher height which we already did test in other test. For node not playing with height 0 we already have test from before where we didn't even have height and we just added default one now which is zero. So I did add one new test with changing height to the same node, first it fails, then we change height and wait and then it succeeded. |
Mine blocks until you get an anchor that satisfies being out of the node's proximity with the storageDepth, but it can play with height > 0. |
yes, that test was added. |
Implementation of SWIP on how to extend node storage capacity dedicated to the reserve to be able to calibrate operators' profitability.
More detail on this in SWIP writeup
ethersphere/SWIPs#56