-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter non-TCF system
s from datamap (fides)
#4468
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Passing run #5540 ↗︎
Details:
Review all test suite changes for PR #4468 ↗︎ |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4468 +/- ##
==========================================
- Coverage 87.11% 87.08% -0.03%
==========================================
Files 331 332 +1
Lines 20478 20502 +24
Branches 2639 2641 +2
==========================================
+ Hits 17839 17855 +16
- Misses 2172 2180 +8
Partials 467 467 ☔ View full report in Codecov by Sentry. |
6984415
to
17b8e9a
Compare
system
ssystem
s from datamap (fides)
|
Co-authored-by: Kelsey Thomas <[email protected]>
part of PROD-1399
done alongside https://github.com/ethyca/fidesplus/pull/1241
Description Of Changes
Provides some basic utility functions to allow us to easily retrieve only non-TCF systems (i.e. systems that are neither GVL nor AC vendor-based) from our DB.
This is just a starting point, we may want to refactor these utilities if/when they're needed in other places. For now, we need them in fidesplus to complete https://ethyca.atlassian.net/browse/PROD-1399.
This PR also includes the FE change necessary to display the requested notice on the datamap page.
Code Changes
System
recordsSteps to Confirm
see fidesplus PR for testing steps
Pre-Merge Checklist
CHANGELOG.md