Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter non-TCF systems from datamap (fides) #4468

Merged
merged 13 commits into from
Dec 7, 2023
Merged

Conversation

adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Nov 29, 2023

part of PROD-1399

done alongside https://github.com/ethyca/fidesplus/pull/1241

Description Of Changes

Provides some basic utility functions to allow us to easily retrieve only non-TCF systems (i.e. systems that are neither GVL nor AC vendor-based) from our DB.

This is just a starting point, we may want to refactor these utilities if/when they're needed in other places. For now, we need them in fidesplus to complete https://ethyca.atlassian.net/browse/PROD-1399.

This PR also includes the FE change necessary to display the requested notice on the datamap page.

Code Changes

  • utility functions to support filtering out GVL and AC systems from queries that retrieve System records
    • some minor reorg of TCF utility code to support the above
  • FE updates to display requested notice on datamap pages if TCF is enabled

Steps to Confirm

see fidesplus PR for testing steps

Pre-Merge Checklist

Copy link

vercel bot commented Nov 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 7, 2023 0:23am

Copy link

cypress bot commented Nov 29, 2023

Passing run #5540 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 78c9949 into 56caa30...
Project: fides Commit: 5fdfafcffc ℹ️
Status: Passed Duration: 00:34 💡
Started: Dec 7, 2023 12:31 PM Ended: Dec 7, 2023 12:32 PM

Review all test suite changes for PR #4468 ↗︎

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (a8efadd) 87.11% compared to head (a268050) 87.08%.

Files Patch % Lines
src/fides/api/util/tcf/__init__.py 63.63% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4468      +/-   ##
==========================================
- Coverage   87.11%   87.08%   -0.03%     
==========================================
  Files         331      332       +1     
  Lines       20478    20502      +24     
  Branches     2639     2641       +2     
==========================================
+ Hits        17839    17855      +16     
- Misses       2172     2180       +8     
  Partials      467      467              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsachs adamsachs force-pushed the asachs/PROD-1399-fides branch from 6984415 to 17b8e9a Compare December 1, 2023 17:59
@adamsachs adamsachs changed the title function to filter non-TCF systems Filter non-TCF systems from datamap (fides) Dec 1, 2023
@galvana galvana self-requested a review December 5, 2023 20:50
@Kelsey-Ethyca
Copy link
Contributor

@adamsachs adamsachs marked this pull request as ready for review December 7, 2023 12:21
@adamsachs
Copy link
Contributor Author

adamsachs commented Dec 7, 2023

awesome thank you @Kelsey-Ethyca! i'll give it one last run through locally after all the changes then i'll plan to merge and cherry pick 👍 - nevermind, feeling pretty comfortable with all the testing we've done, i'll just merge and cherry pick 😄

@adamsachs adamsachs merged commit cbf2ecc into main Dec 7, 2023
41 of 44 checks passed
@adamsachs adamsachs deleted the asachs/PROD-1399-fides branch December 7, 2023 12:41
adamsachs added a commit that referenced this pull request Dec 7, 2023
pattisdr added a commit that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants