Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Center: Create new system from results in modal #5706

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Action Center: Create new system from results in modal #5706

merged 3 commits into from
Jan 29, 2025

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jan 28, 2025 •
edited by jira bot
Loading

Closes HA-292

Description Of Changes

Users should be able to create a new system from the monitor assets without leaving the context of the asset table.

Code Changes

  • Updated System Select to optionally include an "Add new system +" option
  • New, reusable custom select option component to support that new option's style/behavior
  • Create AddNewSystemModal component, mimicking existing Add Vendor modal
  • General updates for consistency
  • Cypress test for new system modal

Steps to Confirm

  1. Checkout and run the backend from Adam's branch in the fidesplus repo (asachs/HJ-295).
  2. Run turbo dev from the clients directory
  3. Visit AdminUI's "About" page and enable the new "Website Monitor" feature flag
  4. Click the "Action center" left nav item
  5. If you receive a message here saying it's disabled, contact Adam to update config.
  6. You should see 2 monitors, which are just dummy data from Adam's BE at the moment.
  7. Click the title or Review link of one of the monitors
  8. Click the row of one of the systems
  9. You will now be viewing this new page containing the result assets within that system
  10. Click the System badge in one of the rows. This will open a dropdown.
  11. Click the first option in the dropdown: "Add new system +"
  12. A modal should appear with our standard vendor/system selector. Pick an option from that list which should also auto-complete the description from compass.
  13. Click the "Save" button of the modal.
  14. A relevant toast message should appear and the row should disappear.
  15. Click the breadcrumb link of the monitor name (up one level). The system you just picked should appear in the list of systems now.
  16. Click the new system
  17. The asset should now be the only row in this system's table.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@gilluminate gilluminate requested a review from jpople January 28, 2025 18:19
@vercel Vercel
Copy link

vercel bot commented Jan 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 5:44pm

@cypress Cypress
Copy link

cypress bot commented Jan 28, 2025 •
edited
Loading

fides    Run #12005

Run Properties:  status check passed Passed #12005  •  git commit 0ee42e082a ℹ️: Merge 6231075f6c0d775c2a555219fc22aae12a787391 into 2160ecab3a2f93427c033e38d301...
Project fides
Branch Review refs/pull/5706/merge
Run status status check passed Passed #12005
Run duration 00m 50s
Commit git commit 0ee42e082a ℹ️: Merge 6231075f6c0d775c2a555219fc22aae12a787391 into 2160ecab3a2f93427c033e38d301...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

jpople
jpople reviewed Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-01-29 at 10 04 21

Tested locally. Creating new systems with Compass works as intended, but if I "manually" create a system by entering a new system name and save it the row remains in the table, is this expected?

@gilluminate
Copy link
Contributor Author

@jpople this is not expected but it is a backend issue. I'm asking Adam to take a look. Let's not hold up this PR for that fix.

jpople
jpople approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, all good to merge then.

@gilluminate
Copy link
Contributor Author

@jpople Thanks! Good find BTW

@gilluminate gilluminate merged commit 6bf157a into main Jan 29, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/HJ-292/action-center-create-new branch January 29, 2025 17:57
@cypress Cypress
Copy link

cypress bot commented Jan 29, 2025

fides    Run #12010

Run Properties:  status check passed Passed #12010  •  git commit 6bf157aac3: Action Center: Create new system from results in modal (#5706)
Project fides
Branch Review main
Run status status check passed Passed #12010
Run duration 00m 47s
Commit git commit 6bf157aac3: Action Center: Create new system from results in modal (#5706)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @jpople