Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Action Center: Bulk assign system #5709

Merged
merged 3 commits into from
Jan 29, 2025
Merged

Action Center: Bulk assign system #5709

merged 3 commits into from
Jan 29, 2025

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Jan 29, 2025 •
edited
Loading

Closes HA-387

Description Of Changes

Users should be able to assign a system to multiple assets at once.

Code Changes

  • New Assign system modal
  • New option in bulk action dropdown

Steps to Confirm

  1. Checkout and run the backend from Adam's branch in the fidesplus repo (asachs/HJ-295).
  2. Run turbo dev from the clients directory
  3. Visit AdminUI's "About" page and enable the new "Website Monitor" feature flag
  4. Click the "Action center" left nav item
  5. If you receive a message here saying it's disabled, contact Adam to update config.
  6. You should see 2 monitors, which are just dummy data from Adam's BE at the moment.
  7. Click the title or Review link of one of the monitors
  8. Click the row of one of the systems
  9. You will now be viewing this new page containing the result assets within that system
  10. Check the box of a few rows
  11. Click the Actions dropdown and select Add system
  12. Pick a system from the list and Save
  13. A relevant toast should appear and the assets should move to their assigned bucket

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@gilluminate gilluminate requested a review from jpople January 29, 2025 18:12
@vercel Vercel
Copy link

vercel bot commented Jan 29, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 7:39pm

@cypress Cypress
Copy link

cypress bot commented Jan 29, 2025 •
edited
Loading

fides    Run #12027

Run Properties:  status check passed Passed #12027  •  git commit cfe2fa77b7 ℹ️: Merge 4cf7da7215af1816b38d4eb766c43a70ef09ff63 into 3d494069c005105634a89c6b49da...
Project fides
Branch Review refs/pull/5709/merge
Run status status check passed Passed #12027
Run duration 00m 48s
Commit git commit cfe2fa77b7 ℹ️: Merge 4cf7da7215af1816b38d4eb766c43a70ef09ff63 into 3d494069c005105634a89c6b49da...
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

jpople
jpople approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, looking good and working as intended.

@gilluminate gilluminate merged commit 48f0974 into main Jan 29, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/HA-387/action-center-bulk-assign branch January 29, 2025 19:51
@cypress Cypress
Copy link

cypress bot commented Jan 29, 2025

fides    Run #12028

Run Properties:  status check passed Passed #12028  •  git commit 48f0974a05: Action Center: Bulk assign system (#5709)
Project fides
Branch Review main
Run status status check passed Passed #12028
Run duration 00m 49s
Commit git commit 48f0974a05: Action Center: Bulk assign system (#5709)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpople jpople jpople approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @jpople