Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved dataset validation #5744

Open
wants to merge 31 commits into
base: main
Choose a base branch
from
Open

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Feb 7, 2025

Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Feb 13, 2025 2:33am

Copy link

cypress bot commented Feb 7, 2025

fides    Run #12388

Run Properties:  status check passed Passed #12388  •  git commit 777c8e04d5 ℹ️: Merge 39b132452997656ccc236077046a3491cb8ae68c into 410758265edbec57d7e2389c3907...
Project fides
Branch Review refs/pull/5744/merge
Run status status check passed Passed #12388
Run duration 00m 48s
Commit git commit 777c8e04d5 ℹ️: Merge 39b132452997656ccc236077046a3491cb8ae68c into 410758265edbec57d7e2389c3907...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 86.58537% with 44 lines in your changes missing coverage. Please review.

Project coverage is 87.22%. Comparing base (29f3415) to head (49d3053).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/service/dataset/dataset_service.py 74.80% 31 Missing and 1 partial ⚠️
...rc/fides/api/api/v1/endpoints/dataset_endpoints.py 82.75% 5 Missing ⚠️
.../service/dataset/validation_steps/data_category.py 92.30% 2 Missing and 1 partial ⚠️
...ides/service/dataset/validation_steps/traversal.py 87.50% 2 Missing and 1 partial ⚠️
src/fides/api/models/datasetconfig.py 96.15% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (86.58%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5744      +/-   ##
==========================================
+ Coverage   86.88%   87.22%   +0.33%     
==========================================
  Files         389      395       +6     
  Lines       24227    24361     +134     
  Branches     2624     2634      +10     
==========================================
+ Hits        21049    21248     +199     
+ Misses       2611     2539      -72     
- Partials      567      574       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants