Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run smoke test on main or release branches #5754

Merged
merged 2 commits into from
Feb 12, 2025

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

Smoke test takes 15-20minutes to run. The plan is that expensive tests should run nightly. The immediate improvement here is to run them on main or release branches, but not on each PR:

Code Changes

  • remove pull request from the workflow trigger list

Steps to Confirm

  1. Check that the e2e are not running in this pr

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 12, 2025 8:08pm

@lucanovera lucanovera merged commit 7c5657a into main Feb 12, 2025
11 of 12 checks passed
@lucanovera lucanovera deleted the only-run-smoke-test-on-main branch February 12, 2025 20:05
Copy link

cypress bot commented Feb 12, 2025

fides    Run #12435

Run Properties:  status check passed Passed #12435  •  git commit 7c5657ab8d: Only run smoke test on main or release branches (#5754)
Project fides
Branch Review main
Run status status check passed Passed #12435
Run duration 00m 49s
Commit git commit 7c5657ab8d: Only run smoke test on main or release branches (#5754)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants