-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LJ-458-FE-Consent-reporting-page-initial-UI #5839
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
…-reporting-page-initial-UI
Testing looks good, but when I have used the pagination and click refresh, I was expecting that to take me back to the first page. Maybe that's by design that it doesn't, but especially in the case of looking for new entries I found it a little disorienting that it didn't. |
clients/admin-ui/src/features/consent-reporting/ConsentReportDownloadModal.tsx
Show resolved
Hide resolved
clients/admin-ui/src/features/consent-reporting/consent-reporting.slice.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/consent-reporting/consent-reporting.slice.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/consent-reporting/consent-reporting.slice.ts
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/consent-reporting/hooks/useConsentReportingTableColumns.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not for this PR, but I would love to see us update the filenames in this directory to take a more standard approach (eg. date-range.d.ts
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Great work
CHANGELOG.md
Outdated
@@ -23,6 +23,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o | |||
|
|||
### Added | |||
- DB model support for Attachments [#5784](https://github.com/ethyca/fides/pull/5784) https://github.com/ethyca/fides/labels/db-migration | |||
- Added a consent reporting table and consent lookup feature [#5839](https://github.com/ethyca/fides/pull/5839) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this getting cherry-picked to 2.56.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm asking adam about it, if I can make that patch release, I'll move the changelog. Thanks for the attention to details!
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 49s |
Commit |
|
Committer | Lucano Vera |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Description Of Changes
Implement consent reporting table and consent record lookup modal.
Code Changes
Screenshots
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works