Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJ-458-FE-Consent-reporting-page-initial-UI #5839

Merged
merged 49 commits into from
Mar 7, 2025

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Mar 4, 2025

Description Of Changes

Implement consent reporting table and consent record lookup modal.

Code Changes

  • Add table to consent reporting page
  • Replace double date input with ant's range picker
  • Include dayjs library
  • Add new endpoints to consent reporting slice
  • Add modal to lookup current privacy preferences

Screenshots

Screen Shot 2025-03-07 at 11 27 22
Screen Shot 2025-03-07 at 11 27 31

Steps to Confirm

  1. Login to admin ui
  2. Go to Consent > Consent Reporting (if the option isn't there, enable Consent Reporting in Settings > About Fides)
  3. Check consent records are being displayed in a table
  4. Check modifying the date range updates the results in the table
  5. Check download button opens a modal and button to download report works
  6. In a new tab, use demo page to open a consent modal and save new preferences (http://localhost:3001/fides-js-demo.html?geolocation=us-ca or http://localhost:3001/fides-js-demo.html?geolocation=eea)
  7. Back in consent reporting, click the Refresh button
  8. Check the new consent record appeared in the table and a success toast is shown
  9. Look at the table for a record that isn't TCF, copy the User device ID
  10. Open the dropdown (three dots in the top right corner of the table) and select 'Consent preference lookup'
  11. Paste the device id in the search bar and hit search
  12. Check the results are shown in the table below

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2025 8:09pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 7, 2025 8:09pm

@gilluminate
Copy link
Contributor

Testing looks good, but when I have used the pagination and click refresh, I was expecting that to take me back to the first page. Maybe that's by design that it doesn't, but especially in the case of looking for new entries I found it a little disorienting that it didn't.

@lucanovera lucanovera changed the title Draft: LJ-458-FE-Consent-reporting-page-initial-UI LJ-458-FE-Consent-reporting-page-initial-UI Mar 7, 2025
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not for this PR, but I would love to see us update the filenames in this directory to take a more standard approach (eg. date-range.d.ts)

Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Great work

CHANGELOG.md Outdated
@@ -23,6 +23,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o

### Added
- DB model support for Attachments [#5784](https://github.com/ethyca/fides/pull/5784) https://github.com/ethyca/fides/labels/db-migration
- Added a consent reporting table and consent lookup feature [#5839](https://github.com/ethyca/fides/pull/5839)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this getting cherry-picked to 2.56.2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm asking adam about it, if I can make that patch release, I'll move the changelog. Thanks for the attention to details!

@lucanovera lucanovera merged commit 7f21d2e into main Mar 7, 2025
18 checks passed
@lucanovera lucanovera deleted the LJ-458-FE-Consent-reporting-page-initial-UI branch March 7, 2025 20:13
Copy link

cypress bot commented Mar 7, 2025

fides    Run #12642

Run Properties:  status check passed Passed #12642  •  git commit 7f21d2ede2: LJ-458-FE-Consent-reporting-page-initial-UI (#5839)
Project fides
Branch Review main
Run status status check passed Passed #12642
Run duration 00m 49s
Commit git commit 7f21d2ede2: LJ-458-FE-Consent-reporting-page-initial-UI (#5839)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants