Fixed load_samples to wrap variables in quotes to prevent YAML parsing errors

[NevilleS]

Description Of Changes

Unfortunately the variable expansion logic in the FIDES__DATABASE__LOAD_SAMPLES handling can result in loading a character like &, which YAML parsing then tries to interpret as an anchor, and then it fails to load the sample data.

Fides' startup routine is resilient to that failure, it just continues starting up but aborts loading the rest of the sample data, which is a subtle footgun and caught us in a test environment recently!

This addresses this by wrapping all the variables we load from the template connections in quotes, and adds some tests to exercise that.

Code Changes

• Update sample connections YML to wrap variables in quotes
• Add test to ensure that sample connections YML loads safely with special characters in variables
• Add test to demonstrate what will/won't fail to load, for future engineers

Steps to Confirm

1. Run unit tests and confirm
2. Use FIDES__DATABASE__LOAD_SAMPLES=1 and insert ENV variables like FIDES_DEPLOY__CONNECTORS__POSTGRES__HOST=&123 and confirm that YAML errors do not occur

Pre-Merge Checklist

• Issue requirements met
• All CI pipelines succeeded
• CHANGELOG.md updated
  • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
  • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
• Followup issues:
  • Followup issues created (include link)
  • No followup issues
• Database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!
  • No migrations
• Documentation:
  • Documentation complete, PR opened in fidesdocs
  • Documentation issue created in fidesdocs
  • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • No documentation updates required

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
fides-privacy-center	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 8, 2025 0:35am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)			Mar 8, 2025 0:35am

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (7f21d2e) to head (204aa7b).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5858   +/-   ##
=======================================
  Coverage   87.01%   87.01%           
=======================================
  Files         407      407           
  Lines       25123    25123           
  Branches     2706     2706           
=======================================
  Hits        21862    21862           
  Misses       2678     2678           
  Partials      583      583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adamsachs]

👍 thanks for the good test coverage!

[cypress]

fides    Run #12644

Run Properties:   Passed #12644  •  238bad5aaa: Fixed load_samples to wrap variables in quotes to prevent YAML parsing errors (#...

Project	fides
Branch Review	main
Run status	Passed #12644
Run duration	00m 50s
Commit	238bad5aaa: Fixed load_samples to wrap variables in quotes to prevent YAML parsing errors (#...
Committer	Neville Samuell
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	5
View all changes introduced in this branch ↗︎