Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJ-474 Refactor privacy request processing to never re-use sessions #5862

Merged
merged 3 commits into from
Mar 11, 2025

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Mar 10, 2025

Closes LJ-474

Description Of Changes

Updated all graph_task code to use new sessions for querying the database rather than relying on self.resources.session. This is for the same reasons as explained in #5834

Steps to Confirm

  1. Update your fides.toml to run DSR 3.0 by setting use_dsr_3_0 = true under [execution]
  2. Create a System (or choose an existing one) and link an integration of your choosing to it (e.g Postgres )
  3. Create a Dataset for that integration and link it to the integration
  4. Run a DSR
  5. Privacy Request should run OK
  6. Change the credentials for the integration so that they are wrong (i.e integration will fail)
  7. Run another DSR
  8. Privacy Request should show in errored status as expected, with the Activity Timeline showing correctly
  9. Update your fides.toml back to DSR 2.0 , and re-run steps 2-8

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 0:24am
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 0:24am

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.02%. Comparing base (728a36a) to head (5adac27).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5862   +/-   ##
=======================================
  Coverage   87.02%   87.02%           
=======================================
  Files         407      407           
  Lines       25125    25141   +16     
  Branches     2706     2706           
=======================================
+ Hits        21864    21880   +16     
  Misses       2678     2678           
  Partials      583      583           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erosselli erosselli added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Mar 10, 2025
@erosselli erosselli marked this pull request as ready for review March 10, 2025 16:01
@erosselli erosselli requested a review from galvana March 10, 2025 16:01
Copy link

cypress bot commented Mar 11, 2025

fides    Run #12652

Run Properties:  status check passed Passed #12652  •  git commit 79061445ae: LJ-474 Refactor privacy request processing to never re-use sessions (#5862)
Project fides
Branch Review main
Run status status check passed Passed #12652
Run duration 00m 50s
Commit git commit 79061445ae: LJ-474 Refactor privacy request processing to never re-use sessions (#5862)
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants