Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add English (UK) as a supported language #5863

Merged
merged 6 commits into from
Mar 11, 2025
Merged

Conversation

wadesdev
Copy link
Contributor

Closes LJ-481 (& FIDES-1806)

Description Of Changes

UI now includes English (UK) as an option for a translation in Notices and Experiences.

Code Changes

Adds "en-GB" to two files: "SupportedLanguage.ts", and "languages.yml", allowing users to add an additional English translation that will be displayed in the UK. Label is "English (UK)" in the UI.

Steps to Confirm

  1. Create an experience that will display in US & UK and set both English & English (UK) for the Language.
  2. Using Cookie House example, set geolocation to GB and confirm English (UK) translation is used.

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2025 3:11pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2025 3:11pm

@wadesdev wadesdev requested review from mfbrown and tvandort March 10, 2025 16:17
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.01%. Comparing base (49f23bc) to head (79f2e57).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5863      +/-   ##
==========================================
+ Coverage   86.70%   87.01%   +0.31%     
==========================================
  Files         407      407              
  Lines       25125    25125              
  Branches     2706     2706              
==========================================
+ Hits        21784    21863      +79     
+ Misses       2766     2678      -88     
- Partials      575      584       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@wadesdev wadesdev merged commit 82fc093 into main Mar 11, 2025
40 of 41 checks passed
@wadesdev wadesdev deleted the FIDES-1806/gb-english-support branch March 11, 2025 16:29
Copy link

cypress bot commented Mar 11, 2025

fides    Run #12654

Run Properties:  status check passed Passed #12654  •  git commit 82fc0935d0: Add English (UK) as a supported language (#5863)
Project fides
Branch Review main
Run status status check passed Passed #12654
Run duration 00m 50s
Commit git commit 82fc0935d0: Add English (UK) as a supported language (#5863)
Committer wadesdev
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants