Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test File Consolidation and Naming Standardization #5865

Merged
merged 3 commits into from
Mar 10, 2025
Merged

Test File Consolidation and Naming Standardization #5865

merged 3 commits into from
Mar 10, 2025

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Mar 10, 2025 •
edited
Loading

These changes focus on code organization and consistency, with no functional changes to the actual implementation.

Test File Consolidation

  • Merged duplicate test files by combining tcf/fidesString.test.ts and fidesString.test.ts into a single fides-string.test.ts
  • All test cases for decodeFidesString, idsFromAcString, and formatFidesStringWithGpp are now in one file
  • Improved test organization with proper setup/teardown hooks

File Renaming

  • Renamed fidesString.ts to fides-string.ts for consistent kebab-case naming
  • Updated all import statements across the codebase to reference the new file name

GPP Testing Enhancement

  • Added makeStub() call in gpp/decoder.test.ts to improve test setup

@vercel Vercel
Copy link

vercel bot commented Mar 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 10, 2025 9:55pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Mar 10, 2025 9:55pm

@gilluminate gilluminate changed the title Clean up fides-string and tests Test File Consolidation and Naming Standardization Mar 10, 2025
@gilluminate gilluminate force-pushed the gill/clean-up-tests branch from 49d4dc6 to a87b6d2 Compare March 10, 2025 21:54
NevilleS
NevilleS approved these changes Mar 10, 2025
View reviewed changes
Copy link
Contributor

@NevilleS NevilleS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gilluminate gilluminate merged commit 728a36a into main Mar 10, 2025
18 checks passed
@gilluminate gilluminate deleted the gill/clean-up-tests branch March 10, 2025 22:29
@cypress Cypress
Copy link

cypress bot commented Mar 10, 2025

fides    Run #12651

Run Properties:  status check passed Passed #12651  •  git commit 728a36a9ff: Test File Consolidation and Naming Standardization (#5865)
Project fides
Branch Review main
Run status status check passed Passed #12651
Run duration 00m 48s
Commit git commit 728a36a9ff: Test File Consolidation and Naming Standardization (#5865)
Committer Jason Gill
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NevilleS NevilleS NevilleS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gilluminate @NevilleS