-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supporting more use cases for the log_context decorator #5866
Supporting more use cases for the log_context decorator #5866
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
func("something", task_id="abc123") | ||
func("something", "abc123") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This typo is why I missed it the first time around 😵💫
Codecov ReportAttention: Patch coverage is
❌ Your patch check has failed because the patch coverage (82.35%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5866 +/- ##
==========================================
- Coverage 87.02% 87.01% -0.01%
==========================================
Files 407 407
Lines 25125 25142 +17
Branches 2706 2712 +6
==========================================
+ Hits 21864 21878 +14
- Misses 2678 2680 +2
- Partials 583 584 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤩 Very cool
fides
|
Project |
fides
|
Branch Review |
main
|
Run status |
|
Run duration | 00m 51s |
Commit |
|
Committer | Adrian Galvan |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
5
|
View all changes introduced in this branch ↗︎ |
Closes LJ-488
Description Of Changes
Fixing bug where positional arguments were not being captured correctly by the
@log_context
decorator.Code Changes
Steps to Confirm
privacy_request_id
as extra context for the following logPre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works