Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LJ-483 Update hover menu state #5868

Merged
merged 7 commits into from
Mar 12, 2025
Merged

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Mar 11, 2025

Description Of Changes

Update the hover state of the sub items in the menu to have a neutral-800 background and neutral-200 text color.

Code Changes

  • Added scss rule to use neutral 800 color upon hovering dark subitems
  • Removed scss rule that changed the hover color to full-white (the result is that it keeps the neutral-200 color now)

Steps to Confirm

  1. Login to admin ui
  2. Hover over the menu items
  3. Check the background is neutral-800 and the text color stays with the neutral-200 color
  4. Check hover state doesn't apply to group level items, only to subitems in the menu

Screenshots

Before:
Captura de pantalla 2025-03-11 a la(s) 10 35 46 a  m

After:
Captura de pantalla 2025-03-11 a la(s) 10 43 18 a  m

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 0:17am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2025 0:17am

@lucanovera lucanovera merged commit 445a762 into main Mar 12, 2025
18 checks passed
@lucanovera lucanovera deleted the LJ-483-FE-Update-menu-hover-state branch March 12, 2025 12:31
Copy link

cypress bot commented Mar 12, 2025

fides    Run #12659

Run Properties:  status check passed Passed #12659  •  git commit 445a7625cf: LJ-483 Update hover menu state (#5868)
Project fides
Branch Review main
Run status status check passed Passed #12659
Run duration 00m 50s
Commit git commit 445a7625cf: LJ-483 Update hover menu state (#5868)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants