Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Cypress workflows to relevant PR changes #5871

Merged
merged 4 commits into from
Mar 12, 2025

Conversation

gilluminate
Copy link
Contributor

@gilluminate gilluminate commented Mar 11, 2025

Description Of Changes

  • Pulls Cypress jobs from general frontend checks workflow
  • Creates separate workflow for respective Cypress jobs so that they only run when PR contains changes in the appropriate directories (pull_request.paths)

The goal is to reduce the need to wait for all Cypress tests to complete on a PR where only one codebase or the other has been changed. (Note: All tests still run after merge to main/release branches.)

Copy link

vercel bot commented Mar 11, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-privacy-center ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 12, 2025 3:57pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Mar 12, 2025 3:57pm

Copy link

codecov bot commented Mar 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.06%. Comparing base (660bd4d) to head (a7699e2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5871      +/-   ##
==========================================
+ Coverage   86.74%   87.06%   +0.31%     
==========================================
  Files         408      408              
  Lines       25320    25320              
  Branches     2726     2726              
==========================================
+ Hits        21965    22045      +80     
+ Misses       2776     2688      -88     
- Partials      579      587       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@lucanovera lucanovera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great first step into speeding up our tests. Approved!

@gilluminate gilluminate merged commit fdb0e48 into main Mar 12, 2025
20 checks passed
@gilluminate gilluminate deleted the gill/pr-split-cypress-workflows branch March 12, 2025 16:01
Copy link

cypress bot commented Mar 12, 2025

fides    Run #12662

Run Properties:  status check passed Passed #12662  •  git commit fdb0e4867e: Split Cypress workflows to relevant PR changes (#5871)
Project fides
Branch Review main
Run status status check passed Passed #12662
Run duration 00m 50s
Commit git commit fdb0e4867e: Split Cypress workflows to relevant PR changes (#5871)
Committer Jason Gill
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 5
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants