Fixed log operator (and added ==) for Sim3 #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
actually, is this unit tested? if so, maybe it's worth adding at least a very simple test to check it? |
|
😬 maybe. Ok, I'll add one some time this week. |
|
thanks for the swift review so far! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hope this non-interface-but-result change does not break anyones code that uses the log operator :( . However, I made a mistake when implementing the Sim3 log operator previously. I should have taken the log of the scale and not just the scale as seventh coefficient. Previously, lim_{n->inf} exp(1/n log(any Sim3)) did not approach identity. It does now.
Also added operator ==. @dymczykm ptal