You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems like the only thing that stops us from updating torch is saving on disk. We should fix this by changing SaveNNMixin.
Using cloudpickle fixes the issue only for torch-1.13, but it doesn't work on torch-2.0.
Proposal
The goal is to fix SaveNNMixin to work with new torch versions.
We should try to use state_dict for saving, not saving the whole object with pickle/dill/cloudpickle. Probably, it will be useful to separate state of the object into torch nn and other components. Class etna.pipeline.mixins.SaveModelPipelineMixin can be useful as a reference of how it can be done.
After doing the task the requirement on torch should be weakened to include 1.13 and 2.0 versions.
Test cases
Fix existing tests
Check manually that on torch-1.13 and torch-2.0 tests.test_models.nn are working
Additional context
No response
The text was updated successfully, but these errors were encountered:
Issue by Mr-Geekman
Thursday May 25, 2023 at 14:09 GMT
Originally opened as tinkoff-ai#1271
🚀 Feature Request
It seems like the only thing that stops us from updating torch is saving on disk. We should fix this by changing
SaveNNMixin
.Using
cloudpickle
fixes the issue only for torch-1.13, but it doesn't work on torch-2.0.Proposal
The goal is to fix
SaveNNMixin
to work with new torch versions.We should try to use
state_dict
for saving, not saving the whole object withpickle
/dill
/cloudpickle
. Probably, it will be useful to separate state of the object into torch nn and other components. Classetna.pipeline.mixins.SaveModelPipelineMixin
can be useful as a reference of how it can be done.After doing the task the requirement on
torch
should be weakened to include 1.13 and 2.0 versions.Test cases
tests.test_models.nn
are workingAdditional context
No response
The text was updated successfully, but these errors were encountered: