Rework saving for DL models #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
===========================================
+ Coverage 9.35% 89.24% +79.88%
===========================================
Files 195 195
Lines 12545 12596 +51
===========================================
+ Hits 1174 11241 +10067
+ Misses 11371 1355 -10016
☔ View full report in Codecov by Sentry. |
|
🚀 Deployed on https://deploy-preview-98--etna-docs.netlify.app |
d-a-bunin
commented
Oct 4, 2023
| def _save_state(self, archive: zipfile.ZipFile): | ||
| with archive.open("object.pkl", "w", force_zip64=True) as output_file: | ||
| dill.dump(self, output_file) | ||
| def _save_state(self, archive: zipfile.ZipFile, skip_attributes: Sequence[str] = ()): |
There was a problem hiding this comment.
I tried to rework _save_state to make other mixins simpler.
d-a-bunin
commented
Oct 4, 2023
| @@ -73,7 +73,7 @@ types-Deprecated = "1.2.9" | |||
|
|
|||
| prophet = {version = "^1.0", optional = true} | |||
|
|
|||
| torch = {version = ">=1.8.0,<1.12.0", optional = true} | |||
| torch = {version = ">=1.8.0,<3", optional = true} | |||
There was a problem hiding this comment.
I checked torch==1.13.1 and torch==2.0.1.
d-a-bunin
commented
Oct 4, 2023
| self.size = size | ||
| self.init_model = init_model | ||
| if init_model: | ||
| self.model = MLPNet( |
There was a problem hiding this comment.
I wasn't very easy to create DeepAR model here to be more accurate with the testing.
d-a-bunin
commented
Oct 4, 2023
| @@ -43,3 +44,14 @@ def test_deepstate_model_run_weekly_overfit_with_scaler(ts_dataset_weekly_functi | |||
|
|
|||
| mae = MAE("macro") | |||
| assert mae(ts_test, future) < 0.001 | |||
|
|
|||
|
|
|||
| def test_save_load(example_tsds): | |||
There was a problem hiding this comment.
This test was forgotten and I added it.
d-a-bunin
commented
Oct 4, 2023
| @@ -43,6 +43,9 @@ def __repr__(self): | |||
| args_str_representation += f"{arg} = {repr(value)}, " | |||
| return f"{self.__class__.__name__}({args_str_representation})" | |||
|
|
|||
| def _get_init_parameters(self): | |||
There was a problem hiding this comment.
Added for simplification.
d-a-bunin
commented
Oct 4, 2023
| def _save_pl_model(archive: zipfile.ZipFile, filename: str, model: "LightningModule"): | ||
| with archive.open(filename, "w", force_zip64=True) as output_file: | ||
| to_save = { | ||
| "class": BaseMixin._get_target_from_class(model), |
There was a problem hiding this comment.
This saving can potentially be improved.
brsnw250
requested changes
Oct 5, 2023
# Conflicts: # CHANGELOG.md # poetry.lock
brsnw250
previously approved these changes
Oct 9, 2023
brsnw250
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
save/loadfor all DL modelsClosing issues
Closes #32.