Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve performance by reducing the number of times the same data is parsed #47

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Improve performance by reducing the number of times the same data is parsed #47

wants to merge 3 commits into from

Conversation

martinreichart
Copy link
Contributor

  1. getJSONStringForValidation(external: external, payload: payload) is not unnecessarily repeated in the forEach loop for every rule
  2. the JsonLogic object is created only once in the Rule and stored in a private var. This avoids the rather expensive parsing of the JsonLogic object many times if the same rule is evaluated for many certificates

@martinreichart martinreichart requested a review from a team as a code owner September 22, 2021 14:15
@martinreichart
Copy link
Contributor Author

@alexchornyi @SchulzeStTSI can you provide an ETA when this PR is reviewed and also just in general maybe clarify how actively this project is still maintained?

@martinreichart
Copy link
Contributor Author

@SchulzeStTSI I saw you merged my PR in SwiftCBOR (thank you!) - any chance to get this one also reviewed and merged soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexchornyi alexchornyi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinreichart @alexchornyi