fix(server): Add validation for empty URL list in citygml packer (#341)

eukarya-inc · Oct 11, 2024 · d0af10b · d0af10b
1 parent f7e2328
commit d0af10b
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/server/citygml/packer.go b/server/citygml/packer.go
@@ -85,6 +85,11 @@ func (p *packer) handlePackRequest(c echo.Context) error {
 			"error":  err.Error(),
 		})
 	}
+	if len(req.URLs) == 0 {
+		return c.JSON(http.StatusBadRequest, map[string]any{
+			"reason": "no urls provided",
+		})
+	}
 	for _, citygmlURL := range req.URLs {
 		u, err := url.Parse(citygmlURL)
 		if err != nil {
@@ -144,7 +149,7 @@ func (p *packer) packAsync(ctx context.Context, req PackAsyncRequest) error {
 			p.conf.CityGMLPackerImage,
 		},
 		Steps: []*cloudbuild.BuildStep{
-			{Args: append([]string{"citygml-packer", "-dest", req.Dest, "-domain", req.Domain}, req.URLs...)},
+			{Name: "citygml-pack", Args: append([]string{"citygml-packer", "-dest", req.Dest, "-domain", req.Domain}, req.URLs...)},
 		},
 	}
 	var err error