Skip to content

Commit

Permalink
chore: added more fields & default values
Browse files Browse the repository at this point in the history
Signed-off-by: Bruno Bressi <[email protected]>
  • Loading branch information
puffitos committed Nov 12, 2024
1 parent ffed19e commit 9cf001f
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 2 deletions.
13 changes: 13 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -74,3 +74,16 @@ e2e-cleanup:
@k3d cluster delete cosign-tests || echo "Deleting cosign tests k3d cluster failed. Continuing..."
@rm -f cosign.pub cosign.key second.pub second.key || echo "Removing files failed. Continuing..."
@echo "Done."

#############
### CHART ###
#############

.PHONY: chart-lint chart
chart-lint:
@echo "Linting chart..."
@helm lint chart

chart:
@echo "Packaging chart..."
@helm package chart
2 changes: 1 addition & 1 deletion chart/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: cosignwebhook
description: A Helm chart for Cosign Webhook Admission Controller
type: application
version: 4.1.1
version: 4.1.1-rc1
appVersion: "4.3.0"
maintainers:
- name: eumel8
Expand Down
3 changes: 2 additions & 1 deletion chart/templates/admission.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,12 +21,12 @@ webhooks:
- admissionReviewVersions:
- v1
name: {{ .Values.admission.webhook.name }}
matchPolicy: {{ .Values.admission.matchPolicy }}
namespaceSelector:
matchExpressions:
- key: kubernetes.io/metadata.name
operator: NotIn
values: [{{ .Release.Namespace | default "default" }}{{- if .Values.admission.exclude }},{{ .Values.admission.exclude }}{{- end }}]
objectSelector: {}
clientConfig:
service:
name: {{ include "cosignwebhook.fullname" . }}
Expand All @@ -42,3 +42,4 @@ webhooks:
scope: "*"
failurePolicy: {{ .Values.admission.failurePolicy }}
sideEffects: {{ .Values.admission.sideEffects }}
timeoutSeconds: {{ .Values.admission.timeoutSeconds }}
3 changes: 3 additions & 0 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ admission:
name: webhook.example.com
# list of excluded namespaces, comma-separated
# exclude: default, kube-system, cattle-system
exclude: ""
matchPolicy: Equivalent
timeoutSeconds: 10

podAnnotations: {}

Expand Down

0 comments on commit 9cf001f

Please sign in to comment.