Quoira: Align the tiptap toolbar with prototype #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thet
force-pushed
the
scrum-2611--toolbar
branch
from
d80db15 to
a31051d
Compare
ale-rt
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: There is an alternative approach for reference which reuses the tiptap toolbar from Euphorie.
If we want to go the path of unifying I'd even recommend to separate the tiptap integration code into a separate package. #293
This PR contains:
Align tiptap texteditor to prototype.
Ref: scrum-2611.
Align checkbox with prototype layout.
Ref: scrum-2883.
Plus:
Looks now like: