Bump MSRV to 1.60 and check MSRV in CI #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syn 2.0.57 requires it. ``` error: failed to select a version for the requirement `syn = "=2.0.57"` candidate versions found which didn't match: 2.0.56, 2.0.55, 2.0.54, ... location searched: crates.io index ```
|
A side effect of rust-lang/cargo#10623 is that pre-1.60 cargo cannot understand weak dependencies and namespace features, so if we generate a lockfile with pre-1.60 cargo, a version compatible with pre-1.60 will be selected. $ cargo +1.56 generate-lockfile
$ cargo tree -p syn
syn v2.0.56
├── proc-macro2 v1.0.79
│ └── unicode-ident v1.0.12
├── quote v1.0.35
│ └── proc-macro2 v1.0.79 (*)
└── unicode-ident v1.0.12
$ cargo +1.56 check
Finished dev [unoptimized + debuginfo] target(s) in 0.58sSo, as long as syn can be compiled with 1.60, I think we can revert this MSRV bump. |
taiki-e
added a commit
to taiki-e/macrotest
that referenced
this pull request
Mar 30, 2024
See eupn#108 (comment) for details.
taiki-e
added a commit
that referenced
this pull request
Mar 30, 2024
See #108 (comment) for details.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
syn 2.0.57 requires it.
dtolnay/syn@585df47
Very confusing error message is due to rust-lang/cargo#10623.