Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SASS nesting, type errors #305

Merged
merged 2 commits into from
Nov 22, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
version: 2
updates:
- package-ecosystem: "github-actions"
directory: "/"
- package-ecosystem: 'github-actions'
directory: '/'
schedule:
interval: "daily"
interval: 'daily'
groups:
actions-deps:
patterns:
- "*"
- '*'

- package-ecosystem: "npm"
directory: "/"
- package-ecosystem: 'npm'
directory: '/'
schedule:
interval: "weekly"
interval: 'weekly'
groups:
patch-minor:
update-types: ["patch", "minor"]
update-types: ['patch', 'minor']
6 changes: 4 additions & 2 deletions src/lib/components/CoverCard.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,12 @@
</h2>
<div class="artist">
{#if cover}
<span class="name">{cover.artists.join(", ")}</span>
<span class="name">{cover.artists.join(', ')}</span>
{/if}
{#if original}
<span class="covering">covering <span class="name">{original.artists.join(", ")}</span></span>
<span class="covering"
>covering <span class="name">{original.artists.join(', ')}</span></span
>
{/if}
</div>
{#if !isSkeleton}
Expand Down
11 changes: 7 additions & 4 deletions src/lib/components/CoverComparison.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -94,17 +94,18 @@
max-width: 100%;
margin-inline: auto;
padding-inline: var(--space-xl);
@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-xl), env(safe-area-inset-left));
padding-inline-end: max(var(--space-xl), env(safe-area-inset-right));
}
scroll-padding-inline: var(--space-xl);
gap: var(--space-l);
grid-template:
'originalAlbum coverAlbum'
'originalContent coverContent';
grid-template-columns: 1fr 1fr;

@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-xl), env(safe-area-inset-left));
padding-inline-end: max(var(--space-xl), env(safe-area-inset-right));
}

@media (max-width: 480px) {
overflow-x: scroll;
overflow-y: hidden;
Expand All @@ -125,6 +126,7 @@

.track:first-child {
scroll-snap-align: start;

@supports (animation-timeline: scroll()) {
animation: dim linear both;
animation-direction: normal;
Expand All @@ -134,6 +136,7 @@

.track:last-child {
scroll-snap-align: end;

@supports (animation-timeline: scroll()) {
animation: dim linear both;
animation-direction: reverse;
Expand Down
11 changes: 6 additions & 5 deletions src/lib/components/Footer.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -42,18 +42,19 @@
width: 100%;
padding-inline: var(--space-m);
padding-block: var(--space-l);
@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-m), env(safe-area-inset-left));
padding-inline-end: max(var(--space-m), env(safe-area-inset-right));
padding-block-end: max(var(--space-l), env(safe-area-inset-bottom));
}
display: grid;
grid-template-areas: 'nav toggle';
grid-template-columns: 1fr fit-content(64px);
align-items: center;
row-gap: var(--space-l);
z-index: 0;

@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-m), env(safe-area-inset-left));
padding-inline-end: max(var(--space-m), env(safe-area-inset-right));
padding-block-end: max(var(--space-l), env(safe-area-inset-bottom));
}

a {
font-weight: var(--font-weight-bold);
text-decoration: underline;
Expand Down
10 changes: 5 additions & 5 deletions src/routes/cover/[slug]/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -125,15 +125,15 @@
padding-block-start: var(--space-xl);
padding-block-end: var(--space-3xl);
padding-inline: var(--space-l);
@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-l), env(safe-area-inset-left));
padding-inline-end: max(var(--space-l), env(safe-area-inset-right));
}
display: flex;
flex-direction: column;
align-items: center;
text-align: center;
text-wrap: balance;
@supports (padding: max(0px)) {
padding-inline-start: max(var(--space-l), env(safe-area-inset-left));
padding-inline-end: max(var(--space-l), env(safe-area-inset-right));
}
}

.title {
Expand All @@ -152,7 +152,7 @@
.artist {
color: var(--mauve-12);

@media (hover: hover) {
@media (hover: hover) {
&:hover {
text-decoration: underline;
text-decoration-color: var(--mauve-9);
Expand Down
2 changes: 0 additions & 2 deletions src/routes/new/+page.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,6 @@
use:autosize
name="description"
class="input"
minRows={2}
maxRows={4}
placeholder="What’s different about this cover?"
/>
<div
Expand Down