-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop 5.8? New minimum 5.10.1? #58
Comments
Interesting. Well, $work is still using 5.8.9, despite my efforts for more than a year. But that's mostly irrelevant, since I couldn't get MSM to work with 5.8.x anyway, due to some annoying OTOH, removing the Devel::BeginLift dependency may actually fix that (I can't remember enough about what the problem was now, but I'm willing to try testing it again). I've put in the work to make all of the new features from @thoughtstream at least fail gracefully on 5.8.x. So, at least for now, I'm not sure I see a huge benefit from ditching support for it. (Though I suppose it would simplify the POD to be able to remove all the "this won't work on older perls" notices.) I'm thinking let's just put this on hold for a little and revisit it once I can figure out how much I can make work on 5.8.9. I've got my little perlbrew farm set up, although I haven't got it automated yet (although that's on my list), so it's not that big a deal for me to do the full spectrum of testing. |
On 2012.10.26 8:07 PM, Buddy Burden wrote:
Huh, I just loaded it all up on 5.8.1 on OS X and it worked like a charm.
Okie doke.
|
The only "problem" I have seen with 5.8.9 at $work is that the 'when FOO' syntax is unsupported. I am moving from 5.8.9 as time allows, which should be RealSoonNow(tm). I have, however, been using it quite heavily in the last few months under 5.8.9, as it removes a boatload of boilerplate parameter marshaling and checking code, and makes the code, at least in my opinion, much easier to read. In short, for the time being, I would vote that the support of 5.8 be held on to for just a bit longer. |
Yes, I think I agree. The
I have no idea if this is still true now that we've ditched Devel::BeginLift, and I don't remember how to reproduce it now. :-/ Hopefully it's not (still true, that is). But I think if people are still stuck on 5.8.x for whatever reason, we should probably have mercy on them. No need to make their lives even harder than they already are. :-D |
FWIW we upgraded from 5.8 at $ORK but only because I pushed it. OTOH if I weren't here we wouldn't be using fancy things like method signatures, so maybe that's not probative. |
Well, at least your push was succesful. :-/ I've been pushing that at my $work for two years now with no luck so far. <sigh> |
Ironically, perls between 5.8.8 and 5.10.1 are the only ones with a 100% PASS, see http://matrix.cpantesters.org/?dist=Method-Signatures%2020131010 ... see #93 |
Right now it appears that because MS depends upon |
Well, that seems wrong ... I thought experimental was just a wrapper around |
I haven't dug into the source code that much, but the Build.PL now requires 5.10.x as a minimum, and experimental.pm itself seems to now depend upon feature.pm, which is obviously 5.10+ only. On the plus side, I discovered this because the travis tests for my pull request (#94) unexpectedly errored on 5.8.x. Thanks for the swift response! :) |
I propose we raise the minimum dependency to 5.10.1.
I don't remember why I made 5.8.1 the minimum, but I don't have any need for it, and I don't test it much any more. Amazingly enough, aside from some silly test mistakes in line numbers, it still works. I'm going to try out travis-ci.org to do CI testing and they don't provide a 5.8.
I'd go with 5.10.1, 5.10.0 has annoying bugs.
The text was updated successfully, but these errors were encountered: