try 9

evaleev · Jan 10, 2024 · 01acdfe · 01acdfe
1 parent 0c9bc4d
commit 01acdfe
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
@@ -56,7 +56,12 @@ if (pybind11_VERSION VERSION_GREATER_EQUAL 2.7.0)
     target_compile_definitions(libint2-python PRIVATE NDEBUG=1)
 endif()
 
-message("QQQQ CXX_COMPILER_ID ${CXX_COMPILER_ID}")
+message("QQQQ CMAKE_CXX_COMPILER_ID ${CMAKE_CXX_COMPILER_ID}")
+target_compile_options(libint2-python
+  PRIVATE
+    #$<$<BOOL:${MSVC}>:/W4>
+    $<$<NOT:$<BOOL:${MSVC}>>:-Wall>
+  )
 
 #find_package(Eigen3 3.3 REQUIRED)
 

diff --git a/src/lib/libint/CMakeLists.txt.export b/src/lib/libint/CMakeLists.txt.export
@@ -342,11 +342,12 @@ if (L2_BUILD_STATIC_LIBS)
       )
     target_compile_definitions(
       int-static
-      INTERFACE
-        $<BUILD_INTERFACE:__COMPILING_LIBINT2=1>
+      PRIVATE
         $<$<BOOL:${MSVC}>:_CRT_NONSTDC_NO_DEPRECATE>
         $<$<BOOL:${MSVC}>:_CRT_NONSTDC_NO_WARNINGS>
         $<$<BOOL:${MSVC}>:_CRT_SECURE_NO_WARNINGS>
+      INTERFACE
+        $<BUILD_INTERFACE:__COMPILING_LIBINT2=1>
       PUBLIC
         $<$<BOOL:${MSVC}>:_USE_MATH_DEFINES>
       )