-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1-e σpVσp #273
The head ref may contain hidden characters: "feature/\u03C3pV\u03C3p"
1-e σpVσp #273
Conversation
Active Todo List for pVp Integrals:
|
…mpute relation ... good luck!
This reverts commit 12c304b.
a716394
to
4c5cb33
Compare
Alas, the sigmas appear in filenames in the export. Windows couldn't handle files
lines
|
@loriab is this something that the compiler does when interpreting the source? or is this something that cmake does when making a unity source? trying to disable unity build to see if this has any effect ... |
I don't think unicode characters in file names should be a problem ... |
9c6056a
to
37fceea
Compare
Longshot (why would the basis fn be called?) but easy to try if removing https://github.com/evaleev/libint/blob/master/include/libint2/basis.h.in#L348-L350 helps. Also note that if you want a shorter time to failure for GHA, can do https://github.com/evaleev/libint/blob/master/.github/workflows/cmake.yml#L161-L165 . Sorry for all the trouble Wiindows is causing. |
And with the latest commit, Mathematica and L2 and my-script-using-L2-V-ints all match in Cartesians. AFAIK, what remains on this PR is:
|
Nice, was thereva real issue with D integrals then? |
indeed: this suggests condo builds ninja using configure.py but looks like one must use CMake and MSVC to build ninja to support UTF! So, indeed, UTF-8 support is not possible on Windows without requiring properly built ninja. P.S. What is wrong with anyone choosing to use Windows? |
@loriab the library now builds but python module does not ... https://github.com/evaleev/libint/actions/runs/7049909124/job/19189926846#step:7:13369 |
2865b86
to
193360c
Compare
|
It might be worth disabling Win / Python in extract+build+install to ensure that the units tests and the HF are still good for windows with the symlink. It'll still fail on the Build& Test Python bindings where it builds pylibint again. |
https://github.com/evaleev/libint/pull/287/files#diff-cdd48abbd3eb8d1c54077449fc74a8de1f29805d2be5d8e5232b7aab76ea7a6fL121-R125 can cut another 7 min off time-to-failure |
193360c
to
22df263
Compare
.github/workflows/cmake.yml
Outdated
@@ -284,7 +284,7 @@ jobs: | |||
-DLIBINT2_PYTHON=ON \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lori suggested turning this OFF if we're still having problems even after this latest version.
looks like the linking always fails ... https://github.com/evaleev/libint/actions/runs/7052599388/job/19198357371#step:8:78 guys, feel free to try but I'm ready to give up. This is extremely annoying. |
Definitely annoying. Best suggestion I have is having eye-friendly and file-friendly versions of the operator strings -- former for the code one looks at and latter for anything generated, for any OS, though the offender is Windows. |
The only other idea I have at this point is to try conda from |
you mean |
That's what I glean from https://github.com/ninja-build/ninja/blob/master/.github/workflows/windows.yml The reservation Jonathon mentioned is that for c-f I need to be able to build the libint recipe from a controlled environment. They're not going to care for pinning consistency about a tool that gets consumed (like the ninja generator), but it may be tricky to get ahold of the software not from the c-f channel. But in terms of figuring out will-cmake-built-win-ninja fix this problem, worth a try. |
084f339
to
dcf0344
Compare
dcf0344
to
89ee10e
Compare
bye |
Presumably need to update unit tests? |
I'm pretty sure you meant to start a new post rather than edit mine. But yes, I'm working on generating the test data now. |
@@ -203,7 +217,7 @@ target_compile_features(libint2_obj PUBLIC "cxx_std_11") | |||
set_target_properties( | |||
libint2_obj | |||
PROPERTIES | |||
UNITY_BUILD TRUE | |||
UNITY_BUILD FALSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
UNITY_BUILD FALSE | |
UNITY_BUILD TRUE |
avoids too many files for high AM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r2g
No description provided.