-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add registerToken support #17
base: master
Are you sure you want to change the base?
Conversation
Thanks for the contribution! Can you please explain the change and why it is needed? Thanks! |
why:
how i understand it:
what it does:
|
@evanlucas let me know if you have more questions or if i should chance something. imho what i added might also be usefull for others. |
Actual for me! |
Hey @flipflopsimsommer. I'm trying to get these PRs taken care of. Can you clean up the conflicts and rebase off current master? I definitely think this is a good addition. |
@bushong1 can do, i will look at it tomorrow |
Signed-off-by: clemo <[email protected]>
a067a97
to
24fc537
Compare
@bushong1 let me know if you need anything else, looking forward of using your repo again. |
@@ -25,6 +25,7 @@ var gcr = require('../lib/gcr') | |||
, sslcert: path | |||
, sslkey: path | |||
, cacert: path | |||
, registerToken: String |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix spacing to align with the others
Okay, i added some comments on cleaning it up. I'm also trying to walk through the logic. So, the main issue is that this application doesn't allow the user to manually set a "Registration Token", and GitLab doesn't allow the user to procure a single-use "Runner Token" outside of the API. To be clear, a Registration Token is what you receive from the gitlab project page/runner registration page. When the application connects the first time, it will take the Runner Token, make a request to This update is trying to allow a gcr instance to register without asking a human for input. Logic chart is as follows:
Does that sound right? |
No description provided.