Fix 'Ignore pages' cache config processing #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem description: Function cache::shouldCache($page) returns false for any page on 'Ignore pages' list and hence function cache::check($page) doesn't call ob_start() for the page. Fucntion cache::generate() is called without arguments. Call cache::shouldCache() without arguments results true for the same 'ignored' page in cache::generate(). Function cache::generate() caches page data from output buffer and adds some headers. But no buffer was created in cache::check() as the page is on 'Ignore page' list. This leads to invalid cache content (no buffer available) and failed headers 'Etag' and 'Last-Modified' (body already sent). Moreover in cache::generate() function call to self::expiry($page) always with $page = null. PS. file class.cache.php still needs some refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description:
Function cache::shouldCache($page) returns false for any page on 'Ignore pages' list and hence function cache::check($page) doesn't call ob_start() for the page.
Fucntion cache::generate() is called without arguments. Call cache::shouldCache() without arguments results true for the same 'ignored' page in cache::generate().
Function cache::generate() caches page data from output buffer and adds some headers. But no buffer was created in cache::check() as the page is on 'Ignore page' list.
This leads to invalid cache content (no buffer available) and failed headers 'Etag' and 'Last-Modified' (body already sent).
Moreover in cache::generate() function call to self::expiry($page) always with $page = null.
PS. file class.cache.php still needs some refactoring.