Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8 support #8

Merged
merged 2 commits into from
Oct 21, 2021
Merged

PHP 8 support #8

merged 2 commits into from
Oct 21, 2021

Conversation

rieschl
Copy link
Member

@rieschl rieschl commented Oct 21, 2021

  • update Code tools
  • update GitHub action
  • remove usage of \Safe\DateTimeImmutable because it's not compatible with PHP 8, yet
  • add LICENCE file

We also need to specify --ignore-platform-reqs at the moment because one dependency doesn't support PHP 8, yet (narrowspark/mimetypes#27).

* update Code tools
* update GitHub action
* remove usage of \Safe\DateTimeImmutable because it's not compatible with PHP 8 yet
* add LICENCE file

We also need to specify --ignore-platform-reqs at the moment because one dependency doesn't support PHP 8, yet (narrowspark/mimetypes#27).
@github-actions
Copy link

PHP 8.0 🎉

Totals Coverage
Statements: 100% ( 66 / 66 )
Methods: 100% ( 19 / 19 )

@github-actions
Copy link

PHP 7.4 🎉

Totals Coverage
Statements: 100% ( 66 / 66 )
Methods: 100% ( 19 / 19 )

@rieschl rieschl merged commit 57ffb70 into master Oct 21, 2021
@rieschl rieschl deleted the php8 branch October 21, 2021 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants