DEVPROD-13189: connect Evergreen test selection route to test selection service #8710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Okta auth redirect
hadjri
approved these changes
Feb 18, 2025
| @@ -23,21 +25,21 @@ type selectTestsHandler struct { | |||
| // this information directly to the test selector. | |||
| type SelectTestsRequest struct { | |||
| // Project is the project identifier. | |||
| Project string `json:"project" bson:"project"` | |||
| Project string `json:"project"` | |||
There was a problem hiding this comment.
nit: can unexport the request struct
There was a problem hiding this comment.
I believe swaggo needs response type to be exported so that it can generate the REST API docs. This struct is for both the request and response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-13189
Description
The test selection service is up and running now, so Evergreen can now proxy the request and send it to the test selection service.
Testing
Tested in staging that making a request to
/rest/v2/select/testssuccessfully sent the request to the test selection service.Documentation
Will update internal dev guide to mention that you have to set
GOPRIVATEif you don't use the makefile.