DEVPROD-11818 Limit build variant names to 100 characters in artifacts path name #8716
+64
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
requested changes
Feb 14, 2025
| @@ -518,7 +518,7 @@ type artifactDownload struct { | |||
|
|
|||
| func getArtifactFolderName(task *service.RestTask) string { | |||
| if evergreen.IsPatchRequester(task.Requester) { | |||
| return fmt.Sprintf("artifacts-patch-%v_%v_%v", task.PatchNumber, task.BuildVariant, task.DisplayName) | |||
There was a problem hiding this comment.
if the build variant is less than 100 characters this will panic; we should case on this. Also shouldn't we do this in the non-patch-requester case as well?
There was a problem hiding this comment.
I think it would be worth adding a unit test for this function, to ensure the output does what you want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-11818
Description
Evergreen fetch uses the build variant as part of the directory name when fetching artifacts. Build variants are sometimes generated with very long names (a user reported a 256 character long path name). This change limits the build variant name to 100 characters.
Documentation
The directory name is currently not documented anywhere (and mongodb/mongo doesn't seem to be relying on it) so I don't think we need to send out any communications or update any documentation. Please let me know if you disagree.