Test member page data #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 27, 2017 13:45
This step enables MemberPage to be extracted to its own file -- which is a step towards running scraper_test against it
This step is required so that `scraper_test` can be run against MemberPage#to_h.
tmtmtmtm
suggested changes
Apr 27, 2017
added 2 commits
April 27, 2017 16:41
Birth dates are not being captured (issue: #5)
tmtmtmtm
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests scraper output against YAML file.
MemberPage#to_h should match the data specified in the YAML.
Part of everypolitician/everypolitician#600 (Ensure every scraper that has been ported to Scraped has a basic YAML test for at least one person)
Note: I've added two TODO comments to 40e8def for issues #2 and #3.