Don't lock down to a specific version of github-pages #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the tests were failing every time there was a new version of the github-pages gem released because we were locking down to a specific version and bundler was complaining. This change means we don't automatically use the latest version from GitHub, which means we will need to run `bundle update` a bit more frequently to ensure we're running against the same version as Github.
|
Closing in favour of #27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tests were failing every time there was a new version of
the github-pages gem released because we were locking down to a specific
version and bundler was complaining.
This change means we don't automatically use the latest version from
GitHub, which means we will need to run
bundle updatea bit morefrequently to ensure we're running against the same version as Github.
This prevents the kind of test failures we're seeing in #25 and #24.