Rename PersonCard#memberships to PersonCard#legislative_memberships #15620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add another method to the PersonCard class which returns cabinet memberships. Therefore it makes sense to rename this method to legislative_memberships to make it clear that it's only returning a subset of the memberships.
chrismytton
force-pushed
the
split-person-card-memberships
branch
from
b5f2b6a to
52bf18b
Compare
chrismytton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
This renames
PersonCard#membershipstoPersonCard#legislative_memberships.Why was this needed?
We want to add a
PersonCard#cabinet_membershipsmethod as part of #24. Therefore it makes sense to rename this method to#legislative_membershipsto make it clear that it's only returning a subset of the memberships.Relevant Issue(s)
Extracted from #15616
Part of #24