chore: skip summary separator if nothing is printed

evilmartians · Nov 14, 2023 · 4294d78 · 4294d78
1 parent d527c1f
commit 4294d78
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/internal/lefthook/lefthook.go b/internal/lefthook/lefthook.go
@@ -15,8 +15,9 @@ import (
 )
 
 const (
-	hookFileMode = 0o755
-	envVerbose   = "LEFTHOOK_VERBOSE" // keep all output
+	hookFileMode   = 0o755
+	envVerbose     = "LEFTHOOK_VERBOSE" // keep all output
+	oldHookPostfix = ".old"
 )
 
 var lefthookContentRegexp = regexp.MustCompile("LEFTHOOK")
@@ -94,7 +95,7 @@ func (l *Lefthook) cleanHook(hook string, force bool) error {
 	}
 
 	// Check if .old file already exists before renaming.
-	exists, err = afero.Exists(l.Fs, hookPath+".old")
+	exists, err = afero.Exists(l.Fs, hookPath+oldHookPostfix)
 	if err != nil {
 		return err
 	}
@@ -107,7 +108,7 @@ func (l *Lefthook) cleanHook(hook string, force bool) error {
 		}
 	}
 
-	err = l.Fs.Rename(hookPath, hookPath+".old")
+	err = l.Fs.Rename(hookPath, hookPath+oldHookPostfix)
 	if err != nil {
 		return err
 	}

diff --git a/internal/lefthook/run.go b/internal/lefthook/run.go
@@ -181,9 +181,15 @@ func printSummary(
 	results []run.Result,
 	logSettings log.SkipSettings,
 ) {
+	summaryPrint := log.Separate
+
+	if logSettings.SkipExecution() || (logSettings.SkipExecutionInfo() && logSettings.SkipExecutionOutput()) {
+		summaryPrint = func(s string) { log.Info(s) }
+	}
+
 	if len(results) == 0 {
 		if !logSettings.SkipEmptySummary() {
-			log.Separate(
+			summaryPrint(
 				fmt.Sprintf(
 					"%s %s %s",
 					log.Cyan("summary:"),
@@ -195,7 +201,7 @@ func printSummary(
 		return
 	}
 
-	log.Separate(
+	summaryPrint(
 		log.Cyan("summary: ") + log.Gray(fmt.Sprintf("(done in %.2f seconds)", duration.Seconds())),
 	)