feat: add interrupt (Ctrl-C) handling #550
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #542
⚡ Summary
Hitting Ctrl-C during commit would terminate
lefthook
immediately, and stashed changes would not be restored. This can be improved by using aNotifyContext
which preventslefthook
from being killed while still terminating subprocesses.Test Plan
.lefthook.toml
# unstaged
at the end of.lefthook.toml
git commit -m 'test'
Ctrl-C
git status
&&git stash list
⠏ waiting: sleep^C
unstaged
comment was missingstash@{0}: lefthook auto backup
unstaged
comment was restored☑️ Checklist