improves image validaation

evmos · Jan 2, 2024 · 4d70bb5 · 4d70bb5
1 parent c853f46
commit 4d70bb5
Show file tree

Hide file tree

Showing 22 changed files with 10 additions and 24 deletions.
diff --git a/.github/workflows/validate_chainconfig.yml b/.github/workflows/validate_chainconfig.yml
@@ -5,7 +5,7 @@ on:
 name: Pull request workflow
 jobs:
   validate_assetlists:
-    name: Check json schema
+    name: Validate Chain Config schema
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code

diff --git a/.github/workflows/validate_tokens.yml b/.github/workflows/validate_tokens.yml
@@ -5,7 +5,7 @@ on:
 name: Pull request workflow
 jobs:
   validate_assetlists:
-    name: Check json schema
+    name: Validate Tokens schema
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code

diff --git a/schema.token.json b/schema.token.json
@@ -14,11 +14,13 @@
     },
     "imgSrc": {
       "type": "string",
-      "description": "Link must be SVG link only. If this image is coming from Github, make sure it has a pattern of 'https://raw.githubusercontent.com/cosmos/chain-registry/master/${chain}/images/${coin}.svg' and the link directly opens the image only and not the site of Github with the image."
+      "description": "Link must be SVG link only. If this image is coming from Github, make sure it has a pattern of 'https://raw.githubusercontent.com/cosmos/chain-registry/master/${chain}/images/${coin}.svg' and the link directly opens the image only and not the site of Github with the image.",
+      "pattern": "^https:\\/\\/.+\\.svg$"
     },
     "pngSrc": {
       "type": "string",
-      "description": "Link must be png source. If this image is coming from Github, make sure it has a pattern of 'https://raw.githubusercontent.com/cosmos/chain-registry/master/${chain}/images/${coin}.png' and the link directly opens the image only and not the site of Github with the image."
+      "description": "Link must be png source. If this image is coming from Github, make sure it has a pattern of 'https://raw.githubusercontent.com/cosmos/chain-registry/master/${chain}/images/${coin}.png' and the link directly opens the image only and not the site of Github with the image.",
+      "pattern": "^https:\\/\\/.+\\.png$"
     },
     "type": {
       "type": "string",

diff --git a/tokens/INJ.json b/tokens/INJ.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "INJ",
   "minCoinDenom": "inj",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/injective/images/inj.png",
   "type": "IBC",
   "exponent": "18",

diff --git a/tokens/NEOK.json b/tokens/NEOK.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "NEOK",
   "minCoinDenom": "neok",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmostation/chainlist/main/chain/evmos/asset/neok.png",
   "type": "IBC",
   "exponent": "18",

diff --git a/tokens/REGEN.json b/tokens/REGEN.json
@@ -2,7 +2,7 @@
   "$schema": "../schema.token.json",
   "coinDenom": "REGEN",
   "minCoinDenom": "uregen",
-  "imgSrc": "",
+
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/regen/images/regen.png",
   "type": "IBC",
   "exponent": "6",

diff --git a/tokens/STARS.json b/tokens/STARS.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "STARS",
   "minCoinDenom": "ustars",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/stargaze/images/stars.png",
   "type": "IBC",
   "exponent": "6",

diff --git a/tokens/TASHI.json b/tokens/TASHI.json
@@ -3,7 +3,7 @@
   "coinDenom": "TASHI",
   "minCoinDenom": "tashi",
   "imgSrc": "https://app.tashi.finance/svgs/tashi-icon.svg",
-  "pngSrc": "https://app.tashi.finance/svgs/tashi-icon.svg",
+  "pngSrc": "https://app.tashi.finance/pngs/tashi-icon.png",
   "type": "IBC",
   "exponent": "18",
   "cosmosDenom": "erc20/0x98fAFD9F714CE0B4bB2870527076F2F314aAed82",

diff --git a/tokens/axlPEPE.json b/tokens/axlPEPE.json
@@ -2,8 +2,8 @@
   "$schema": "../schema.token.json",
   "coinDenom": "axlPEPE",
   "minCoinDenom": "pepe-wei",
-  "imgSrc": "https://assets.coingecko.com/coins/images/29850/large/pepe-token.jpeg",
-  "pngSrc": "https://assets.coingecko.com/coins/images/29850/large/pepe-token.jpeg",
+  "imgSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/ethereum/images/pepe.svg",
+  "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/_non-cosmos/ethereum/images/pepe.png",
   "type": "IBC",
   "exponent": "18",
   "cosmosDenom": "ibc/26E6508A1757E12B15A087E951F5D35E73CF036F0D97BC809E1598D1DD870BED",

diff --git a/tokens/axlRETH.json b/tokens/axlRETH.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "axlRETH",
   "minCoinDenom": "reth-wei",
-  "imgSrc": "https://assets.coingecko.com/coins/images/20764/large/reth.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/20764/large/reth.png",
   "type": "IBC",
   "exponent": "18",

diff --git a/tokens/axlWSTETH.json b/tokens/axlWSTETH.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "axlWSTETH",
   "minCoinDenom": "wsteth-wei",
-  "imgSrc": "https://assets.coingecko.com/coins/images/18834/large/wstETH.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/18834/large/wstETH.png",
   "type": "IBC",
   "exponent": "18",

diff --git a/tokens/gDAI.json b/tokens/gDAI.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "gDAI",
   "minCoinDenom": "dai-wei",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/gravitybridge/images/gdai.png",
   "type": "ERC-20",
   "exponent": "18",

diff --git a/tokens/gUSDC.json b/tokens/gUSDC.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "gUSDC",
   "minCoinDenom": "uusdc",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/gravitybridge/images/gusdc.png",
   "type": "ERC-20",
   "exponent": "6",

diff --git a/tokens/gUSDT.json b/tokens/gUSDT.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "gUSDT",
   "minCoinDenom": "uusdt",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/gravitybridge/images/gusdt.png",
   "type": "ERC-20",
   "exponent": "6",

diff --git a/tokens/gWBTC.json b/tokens/gWBTC.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "gWBTC",
   "minCoinDenom": "satoshi",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/gravitybridge/images/gwbtc.png",
   "type": "ERC-20",
   "exponent": "8",

diff --git a/tokens/gWETH.json b/tokens/gWETH.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "gWETH",
   "minCoinDenom": "wei",
-  "imgSrc": "",
   "pngSrc": "https://raw.githubusercontent.com/cosmos/chain-registry/master/gravitybridge/images/gweth.png",
   "type": "ERC-20",
   "exponent": "18",

diff --git a/tokens/kavaUSDT.json b/tokens/kavaUSDT.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "kavaUSDT",
   "minCoinDenom": "erc20/tether/usdt",
-  "imgSrc": "https://assets.coingecko.com/coins/images/325/small/Tether.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/325/small/Tether.png",
   "type": "IBC",
   "exponent": "6",

diff --git a/tokens/wormBTC.json b/tokens/wormBTC.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "wormBTC",
   "minCoinDenom": "nwbtc",
-  "imgSrc": "https://assets.coingecko.com/coins/images/7598/large/wrapped_bitcoin_wbtc.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/7598/large/wrapped_bitcoin_wbtc.png",
   "type": "IBC",
   "exponent": "8",

diff --git a/tokens/wormETH.json b/tokens/wormETH.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "wormETH",
   "minCoinDenom": "nweth",
-  "imgSrc": "https://assets.coingecko.com/coins/images/32882/large/WETH_%281%29.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/32882/large/WETH_%281%29.png",
   "type": "IBC",
   "exponent": "8",

diff --git a/tokens/wormSOL.json b/tokens/wormSOL.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "wormSOL",
   "minCoinDenom": "nsol",
-  "imgSrc": "https://assets.coingecko.com/coins/images/4128/large/solana.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/4128/large/solana.png",
   "type": "IBC",
   "exponent": "8",

diff --git a/tokens/wormUSDC.json b/tokens/wormUSDC.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "wormUSDC",
   "minCoinDenom": "uusdc",
-  "imgSrc": "https://assets.coingecko.com/coins/images/6319/large/usdc.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/6319/large/usdc.png",
   "type": "IBC",
   "exponent": "6",

diff --git a/tokens/wormUSDT.json b/tokens/wormUSDT.json
@@ -2,7 +2,6 @@
   "$schema": "../schema.token.json",
   "coinDenom": "wormUSDT",
   "minCoinDenom": "uusdt",
-  "imgSrc": "https://assets.coingecko.com/coins/images/17385/large/Tether_new.png",
   "pngSrc": "https://assets.coingecko.com/coins/images/17385/large/Tether_new.png",
   "type": "IBC",
   "exponent": "6",