-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
imp(types): Add crypto and encoding packages #20
Conversation
Important Review skippedAuto reviews are limited to specific labels. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the WalkthroughThe recent updates enhance the evmOS framework by refining naming conventions, introducing new cryptographic functionalities, and improving encoding capabilities. Notable additions include support for secp256k1 keys, hierarchical deterministic wallets, and robust testing for various components. Comment improvements and dependency updates further streamline the codebase, ensuring clarity and reinforcing project alignment with current standards. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Wallet
participant KeyManager
participant Codec
User->>Wallet: Generate New Wallet
Wallet->>KeyManager: Request Key Pair
KeyManager->>Wallet: Return Key Pair
Wallet->>Codec: Register Key Pair
Codec-->>Wallet: Key Pair Registered
Wallet-->>User: New Wallet Generated
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you branch out of PR 19? 😅 this contains also code for the wallet
I base these PR sequentially on each other and point to |
This PR moves the crypto package to the evmOS repository.
The PR has to be merged after #19.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Tests