Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zome_client for client_holon_service #215

Open
wants to merge 4 commits into
base: 188-align-holons-zome-codebase-structure-to-architecture
Choose a base branch
from

Conversation

nphias
Copy link
Collaborator

@nphias nphias commented Feb 6, 2025

zome_client is in the test directory for now.. later to used by the cotext inialisation
being able to build a happ to test with will be needed

@nphias nphias requested a review from evomimic February 6, 2025 16:29
@evomimic
Copy link
Owner

evomimic commented Feb 7, 2025

I don't see any particular reason to merge this partially completed issue at this point. I'm in a bit of a fragile place in my work on #209 so I don't really want to commit or stash my changes on that branch to look at 206.

Why not wait until 206 is completed?

Also... I don't think zome_client can live in the test directory as they are needed by holons_client and we can't have a dependency between src and test. How about just put it in holons_client? I agree it will (eventually) be CALLED from outside holons_client, but the implementation of those functions still belongs inside holons_client.

@nphias nphias force-pushed the 206-client-holon-service branch from 90b85a5 to db94127 Compare February 12, 2025 10:44
@nphias nphias changed the title zome client, prep for context zome_client for client_holon_service Feb 12, 2025
@nphias
Copy link
Collaborator Author

nphias commented Feb 12, 2025

functional build works.. using sweetconductor until we can get the rust client working

@evomimic
Copy link
Owner

evomimic commented Feb 12, 2025

Tried to compile branch 206 and got:
error: could not compile mio (lib) due to 47 previous errors
warning: build failed, waiting for other jobs to finish...

I suspect these are the dependency errors you were noting.

@nphias : please add a comment to this PR with instructions on how to get past these errors.

nphias:
builds for me are you sure you were not building 188 branch where those dependencies used to exist?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

holons_client must not depend on holons_guest. What's driving this dependency?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed a few types:

use holons_guest::query_layer::{Node, NodeCollection, QueryExpression};

@evomimic
Copy link
Owner

Tried to compile branch 206 and got: error: could not compile mio (lib) due to 47 previous errors warning: build failed, waiting for other jobs to finish...

I suspect these are the dependency errors you were noting.

@nphias : please add a comment to this PR with instructions on how to get past these errors.

nphias:
builds for me are you sure you were not building 188 branch where those dependencies used to exist?

Yes. I'm sure I'm trying to compile branch 206. And I'm getting 47 errors. I can try an research this myself, but I thought you might at some point have seen something similar and had a fix. I tried npm run clean and still get the same errors.

|

help: if you import Event, refer to it directly
|
191 - &*(sys_event as *const sys::Event as const Event)
191 + &
(sys_event as *const Event as *const Event)
|

error[E0412]: cannot find type Event in module sys
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/event.rs:217:46
|
217 | struct EventDetails<'a>(&'a sys::Event);
| ^^^^^ not found in sys
|
help: consider importing this struct through its public re-export
|
1 + use crate::event::Event;
|
help: if you import Event, refer to it directly
|
217 - struct EventDetails<'a>(&'a sys::Event);
217 + struct EventDetails<'a>(&'a Event);
|

error[E0412]: cannot find type Events in module sys
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/events.rs:43:17
|
43 | inner: sys::Events,
| ^^^^^^ not found in sys
|
help: consider importing this struct through its public re-export
|
1 + use crate::Events;
|
help: if you import Events, refer to it directly
|
43 - inner: sys::Events,
43 + inner: Events,
|

error[E0433]: failed to resolve: could not find Events in sys
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/events.rs:94:25
|
94 | inner: sys::Events::with_capacity(capacity),
| ^^^^^^ could not find Events in sys
|
help: consider importing this struct through its public re-export
|
1 + use crate::Events;
|
help: if you import Events, refer to it directly
|
94 - inner: sys::Events::with_capacity(capacity),
94 + inner: Events::with_capacity(capacity),
|

error[E0412]: cannot find type Events in module sys
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/events.rs:189:47
|
189 | pub(crate) fn sys(&mut self) -> &mut sys::Events {
| ^^^^^^ not found in sys
|
help: consider importing this struct through its public re-export
|
1 + use crate::Events;
|
help: if you import Events, refer to it directly
|
189 - pub(crate) fn sys(&mut self) -> &mut sys::Events {
189 + pub(crate) fn sys(&mut self) -> &mut Events {
|

error[E0425]: cannot find value listener in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:78:24
|
78 | set_reuseaddr(&listener.inner, true)?;
| ^^^^^^^^ not found in this scope

error[E0425]: cannot find value listener in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:80:15
|
80 | bind(&listener.inner, addr)?;
| ^^^^^^^^ not found in this scope

error[E0425]: cannot find value listener in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:81:17
|
81 | listen(&listener.inner, 1024)?;
| ^^^^^^^^ not found in this scope

error[E0425]: cannot find value listener in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:82:12
|
82 | Ok(listener)
| ^^^^^^^^ not found in this scope

error[E0425]: cannot find value stream in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:97:18
|
97 | connect(&stream.inner, addr)?;
| ^^^^^^ not found in this scope

error[E0425]: cannot find value stream in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:98:12
|
98 | Ok(stream)
| ^^^^^^ not found in this scope

Compiling zerocopy v0.7.35
error[E0425]: cannot find function set_reuseaddr in this scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:78:9
|
78 | set_reuseaddr(&listener.inner, true)?;
| ^^^^^^^^^^^^^ not found in this scope

error[E0599]: no method named register found for struct IoSource<std::net::TcpListener> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:150:20
|
150 | self.inner.register(registry, token, interests)
| ^^^^^^^^ method not found in IoSource<TcpListener>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method register not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item register, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0599]: no method named reregister found for struct IoSource<std::net::TcpListener> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:159:20
|
159 | self.inner.reregister(registry, token, interests)
| ^^^^^^^^^^ method not found in IoSource<TcpListener>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method reregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item reregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0599]: no method named deregister found for struct IoSource<std::net::TcpListener> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:163:20
|
163 | self.inner.deregister(registry)
| ^^^^^^^^^^ method not found in IoSource<TcpListener>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method deregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item deregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/listener.rs:286:9
|
286 | / unsafe {
287 | | #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]
288 | | {
289 | | net::TcpListener::from_raw_fd(listener.into_raw_fd())
... |
294 | | }
295 | | }
| |_________^ expected TcpListener, found ()

error[E0599]: no method named register found for struct IoSource<std::net::TcpStream> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:332:20
|
332 | self.inner.register(registry, token, interests)
| ^^^^^^^^ method not found in IoSource<TcpStream>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method register not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item register, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

Compiling wasm-bindgen-macro-support v0.2.100
error[E0599]: no method named reregister found for struct IoSource<std::net::TcpStream> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:341:20
|
341 | self.inner.reregister(registry, token, interests)
| ^^^^^^^^^^ method not found in IoSource<TcpStream>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method reregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item reregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0599]: no method named deregister found for struct IoSource<std::net::TcpStream> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:345:20
|
345 | self.inner.deregister(registry)
| ^^^^^^^^^^ method not found in IoSource<TcpStream>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method deregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item deregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/tcp/stream.rs:468:9
|
468 | / unsafe {
469 | | #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]
470 | | {
471 | | net::TcpStream::from_raw_fd(stream.into_raw_fd())
... |
476 | | }
477 | | }
| |_________^ expected TcpStream, found ()

error[E0599]: no method named register found for struct IoSource<std::net::UdpSocket> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/udp.rs:626:20
|
626 | self.inner.register(registry, token, interests)
| ^^^^^^^^ method not found in IoSource<UdpSocket>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method register not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item register, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

Compiling thiserror v1.0.69
error[E0599]: no method named reregister found for struct IoSource<std::net::UdpSocket> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/udp.rs:635:20
|
635 | self.inner.reregister(registry, token, interests)
| ^^^^^^^^^^ method not found in IoSource<UdpSocket>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method reregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item reregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0599]: no method named deregister found for struct IoSource<std::net::UdpSocket> in the current scope
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/udp.rs:639:20
|
639 | self.inner.deregister(registry)
| ^^^^^^^^^^ method not found in IoSource<UdpSocket>
|
::: /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/io_source.rs:37:1
|
37 | pub struct IoSource {
| ---------------------- method deregister not found for this struct
|
= help: items from traits can only be used if the trait is implemented and in scope
note: Source defines an item deregister, perhaps you need to implement it
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/event/source.rs:75:1
|
75 | pub trait Source {
| ^^^^^^^^^^^^^^^^

error[E0308]: mismatched types
--> /Users/stevemelville/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mio-1.0.3/src/net/udp.rs:762:9
|
762 | / unsafe {
763 | | #[cfg(any(unix, target_os = "hermit", target_os = "wasi"))]
764 | | {
765 | | net::UdpSocket::from_raw_fd(socket.into_raw_fd())
... |
770 | | }
771 | | }
| |_________^ expected UdpSocket, found ()

Some errors have detailed explanations: E0308, E0412, E0425, E0432, E0433, E0599.
For more information about an error, try rustc --explain E0308.
error: could not compile mio (lib) due to 47 previous errors

@evomimic
Copy link
Owner

@nphias : Zeek just checked out branch 206 and he's getting the same errors that I reported above. So there must be something different between your environment and Zeek/my environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants