-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
zome_client for client_holon_service #215
base: 188-align-holons-zome-codebase-structure-to-architecture
Are you sure you want to change the base?
zome_client for client_holon_service #215
Conversation
I don't see any particular reason to merge this partially completed issue at this point. I'm in a bit of a fragile place in my work on #209 so I don't really want to commit or stash my changes on that branch to look at 206. Why not wait until 206 is completed? Also... I don't think zome_client can live in the test directory as they are needed by holons_client and we can't have a dependency between src and test. How about just put it in holons_client? I agree it will (eventually) be CALLED from outside holons_client, but the implementation of those functions still belongs inside holons_client. |
90b85a5
to
db94127
Compare
functional build works.. using sweetconductor until we can get the rust client working |
Tried to compile branch 206 and got: I suspect these are the dependency errors you were noting. @nphias : please add a comment to this PR with instructions on how to get past these errors.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holons_client must not depend on holons_guest. What's driving this dependency?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed a few types:
use holons_guest::query_layer::{Node, NodeCollection, QueryExpression};
Yes. I'm sure I'm trying to compile branch 206. And I'm getting 47 errors. I can try an research this myself, but I thought you might at some point have seen something similar and had a fix. I tried
help: if you import error[E0412]: cannot find type error[E0412]: cannot find type error[E0433]: failed to resolve: could not find error[E0412]: cannot find type error[E0425]: cannot find value error[E0425]: cannot find value error[E0425]: cannot find value error[E0425]: cannot find value error[E0425]: cannot find value error[E0425]: cannot find value Compiling zerocopy v0.7.35 error[E0599]: no method named error[E0599]: no method named error[E0599]: no method named error[E0308]: mismatched types error[E0599]: no method named Compiling wasm-bindgen-macro-support v0.2.100 error[E0599]: no method named error[E0308]: mismatched types error[E0599]: no method named Compiling thiserror v1.0.69 error[E0599]: no method named error[E0308]: mismatched types Some errors have detailed explanations: E0308, E0412, E0425, E0432, E0433, E0599. |
@nphias : Zeek just checked out branch 206 and he's getting the same errors that I reported above. So there must be something different between your environment and Zeek/my environment. |
zome_client is in the test directory for now.. later to used by the cotext inialisation
being able to build a happ to test with will be needed