Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update request logic to handle error reasons in keyword lists #1006

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

maciejgryka
Copy link

Fixes #1005 by updating request.ex to also handle errors in the form of [reason: reason] in addition to %{reason: reason}.

[x] Run mix format using a recent version of Elixir
[x] Run mix dialyzer to make sure the typing is correct
[x] Run mix test to ensure no tests have broken (also please make sure you've added tests for your particular change, where appropriate).

@bernardd
Copy link
Contributor

Great, thanks very much @maciejgryka. Apologies for the delay in getting to this.

@bernardd bernardd merged commit 9e1aa9f into ex-aws:main Dec 11, 2023
@maciejgryka maciejgryka deleted the 1005-request-error-handling branch January 12, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unhandled error case from do_request
2 participants