feat: progress on problems #36
Merged
+262
−98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/progress-on-problems
ykit00
changed the title
Tatehito
reviewed
Feb 14, 2024
src/app/lib/actions.ts
Outdated
| } | ||
| } | ||
|
|
||
| export async function getUserSolvedProblems( |
There was a problem hiding this comment.
個人的な感覚なので変更するかはお任せしたいですが、dbアクセスするので get より fetchUserSolvedProblems のほうがしっくりくる気がしました
| @@ -36,6 +52,15 @@ const CoursePage: NextPage<{ params: { courseId: string } }> = ({ params }) => { | |||
| const inputValue = event.target.value; | |||
| setLanguageIdToSessionStorage(inputValue); | |||
| setSelectedLanguageId(inputValue); | |||
| getUserSolvedProblems(userId, courseId).then((data) => { | |||
There was a problem hiding this comment.
この処理を handleSelectLanguage 内でやってるのて何か理由ありますか？
問題を正解してから科目一覧に戻ってきた時、言語を再選択しないと最新の進捗が表示されない気がします。useEffect内で動かすといいかもと思いました
There was a problem hiding this comment.
最初 useEffect でやってたんですけど、連鎖で使うと renderしまくりでパフォーマンスがよくなくて。。
言語を再選択しないと最新の進捗が表示されない気がします。
これに対応しつつサーバーサイドでフェッチなどするようにして改善してみましたー
4b9d503
| userId String | ||
| courseId String | ||
| programId String | ||
| languageId String |
There was a problem hiding this comment.
programIdやcourseIdはハードコーディングしてるから、問題IDやコースIDの変更は基本できない（やる場合はUserSolvedProblemのレコードも更新する）のは気をつけないといけないですね・・・💡
There was a problem hiding this comment.
ですね！ どこかでDBを使用するように改善する余地もあるかもしれません！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #33
Self Check
All checks have passedon PR page. (You may leave this box unchecked due to long workflows.)WIP:.yarn test) is passed.yarn lint) is passed.