feat: Add cell color clear function #47
Merged
+63
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ykit00
reviewed
Feb 26, 2024
| event.preventDefault(); | ||
|
|
||
| handleClickCell(columnIndex, rowIndex); | ||
| updateCellColor(undefined, columnIndex, rowIndex); |
There was a problem hiding this comment.
型によるものですが、undefined が引数になるのは結構違和感ありますね。
無色 -> null のほうが自然で使いやすいかもしれないと思いましたがどうでしょう・・？
There was a problem hiding this comment.
@ykit00
たしかに！あらためて調べてみたのですが、undefined: 初期化されていない、null: 利用できない、のような意味合いがありどちらも適していないと思ったのでundefined -> 'white' に変更しました！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #45
Self Check
All checks have passedon PR page. (You may leave this box unchecked due to long workflows.)WIP:.yarn test) is passed.yarn lint) is passed.