refactor: Add tables and change table name #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tatehito
commented
Mar 1, 2024
| courseId String | ||
| programId String | ||
| languageId String | ||
| problemVariables ProblemVariable[] |
There was a problem hiding this comment.
SQliteを利用している場合、Json型はサポート外のようでした。
https://www.prisma.io/docs/orm/overview/databases/sqlite#native-type-mapping-from-prisma-orm-to-sqlite
Int[] も使えなかったので、別テーブルにしてみました。
There was a problem hiding this comment.
JSON対応していないんですね👀
別テーブル化よさそうです！
一つの案としてString型でJSONを保持しておいて、使うときにパースするのもありかも？ 今後時間はかかりそうですがJSON型がサポートされる可能性があるので、その際には移行も楽になるのかもなど思いました！
Tatehito
commented
Mar 1, 2024
| value Int | ||
| } | ||
|
|
||
| model UserCompletedProblem { |
There was a problem hiding this comment.
口頭で話した際は UserCompletedProblems （旧UserSolvedProblem）は一旦作らないとしていましたが、migrationだけのPRをつくりやすい（消してしまうと進捗表示などの部分に手を入れる必要がある）ので残しています。
UserCompletedProblems が不要ということになれば、その際に対応したいと思います。
ykit00
reviewed
Mar 4, 2024
Comment on lines
+52
to
+54
| userProblemSessionId Int | ||
|
|
||
| position Int |
There was a problem hiding this comment.
シンプルな仕組みなので使うことはすくないかもしれませんが、この二つの複合キーでユニーク制約があると安心かもです！
ykit00
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
以下のissue対応に必要なテーブルの作成、テーブル名の変更を行いました。
Self Check
All checks have passedon PR page. (You may leave this box unchecked due to long workflows.)WIP:.yarn test) is passed.yarn lint) is passed.