feat(esl-utils): safeContains traverse utility
#2745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fshovchko
added
enhancement
fshovchko
requested review from
ala-n,
yadamskaya and
abarmina
and removed request for
a team
ala-n
approved these changes
Nov 7, 2024
Co-authored-by: ala'n (Alexey Stsefanovich) <[email protected]>
|
Code Climate has analyzed commit 9880874 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 65.3% (0.0% change). View more on Code Climate. |
ala-n
approved these changes
Nov 8, 2024
NastaLeo
approved these changes
Nov 8, 2024
dshovchko
approved these changes
Nov 8, 2024
|
🎉 This PR is included in version 5.0.0-beta.39 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: #2712
During the implementation of ticket #2712, it was discovered that the combination of checking if a node is an element and using element.contains is frequently needed. To streamline this, an
isSafeContainsutility was introduced.