-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(uip-editor): store editor state #780
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a mixed responsibility issue in the current implementation:
UIPEditor is not a state-holder and should not interact with storage/modal (the actual state-holder) unless it's directly connected with user interaction.
Consider rework of EditorStore integration considering the following points:
- It should observe UIPModel directly or be integrated inside model and core
1.2) Just in case there is a possibility to observe the actual initiator of change inside the core. - Please be aware, that the initial state depends on setting it up inside the core. The editor store is only one of the sources, there is also an anchor and default snippet used as a source. The new logic should be in sync with them in terms of priority and execution time. The UIP should not be affected by extra update events as well.
# Conflicts: # src/core/base/root.ts
There are three small but critical points to accept this feature:
To resolve mentioned problems I recommend the following action items:
|
…d into feat/store-state
…d into feat/store-state
Closes: #617