This repository has been archived by the owner on Jun 11, 2019. It is now read-only.
Not adding rules of a certain ip version if that version hasn't been enabled. #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, individual modules don't have to bother any more whether either IPv4 or IPv6 has been enabled and supported. This means that if you have a rule that could apply to both IPv4 and IPv6, you can just do:
firewall::rule {
destination => '127.0.0.1',
destination_v6 => '::1',
enable_v4 => true, # (default)
enable_v6 => true, # (default)
}
And if the OS supports IPv4 only, the ipv6 rule will be discarded, and if ipv4 is not supported, then only an ipv6 rule will be added.